Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate download progress in the log #58

Open
xxchan opened this issue Apr 3, 2023 · 5 comments
Open

eliminate download progress in the log #58

xxchan opened this issue Apr 3, 2023 · 5 comments
Assignees
Labels
2 - Working <= 5 bug Something isn't working s3

Comments

@xxchan
Copy link

xxchan commented Apr 3, 2023

This produced 5000 line of logs

image

@gencer gencer self-assigned this Apr 3, 2023
@gencer gencer added bug Something isn't working s3 labels Apr 3, 2023
@xxchan
Copy link
Author

xxchan commented Apr 3, 2023

Oh, I think I can suppress log by

  s3:
    args: '--no-progress'

(Not sure whether it should be disabled by default

@gencer
Copy link
Collaborator

gencer commented Apr 3, 2023

Can you try to use args with: --no-progress and test with it?

Let me know the result.

@gencer
Copy link
Collaborator

gencer commented Apr 3, 2023

Oh, I think I can suppress log by

  s3:
    args: '--no-progress'

(Not sure whether it should be disabled by default

Just posted the same thing. Seems you already found the solution.

If it works, we can definitely consider adding this as a default value.

@xxchan
Copy link
Author

xxchan commented Apr 3, 2023

It works risingwavelabs/risingwave#8967
Log size reduced 400KB

@gencer
Copy link
Collaborator

gencer commented Apr 3, 2023

Thanks for the feedback. 🥳

I'll make sure --no-progress is in default arguments.

Also, there will be a check for the existing user-provided arguments. So, no duplicate arguments send to the AWS CLI. (This will make sure your CI will not fail when you upgrade to 2.4.14 (upcoming release))

I'll leave this issue open until this gets internally solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - Working <= 5 bug Something isn't working s3
Projects
None yet
Development

No branches or pull requests

2 participants