Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to talk through the issues of this plug-in modification. #3

Open
mc12345678 opened this issue Nov 14, 2013 · 2 comments
Open

Comments

@mc12345678
Copy link

Modification to this plug-in has been identified to ensure that the code is fully compatible with ZC. To ensure open communication, a way for all involved to talk about the code and other issues would be appreciated.

@daniel-hopkins
Copy link
Owner

Looking forward to having some more collaborators!

@daniel-hopkins
Copy link
Owner

Some of the major changes I made:
  1. I downloaded the packer version of the "responsive" slimbox and manually un-minified it so that I could include it as yui minified js instead.
  2. Updated the jquery call that @DivaVocals added so that it will check to see if there is already a jquery on the page before trying to load latest. (this needs more testing)
  3. moved slimbox to its own js file rather than printing it into the body of the page. (just cleaner looking source code)
  4. removed the autoload block that used to be in slimbox.php (it wasn't actually doing anything because it was getting loaded before the one on autoload_default and therefore getting overwritten).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants