Build HTML files by default #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the build option to a flag instead of feature switch -b option continues to be --build for compatibility Introduced a new flag -B which stops execution without building HTML files
Since build is going to be a flag, it does not make sense to have a switch only for serve
|
Thanks for the PR. The changes look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now to generate HTML files from an epub file, we will do something like below
With this change, (Step 1) will be enough to generate the HTML files. The HTML files will be generated even if the
-bflag is not specified.If
-Bflag is specified, the execution will stop without any post conversions.In addition to this,
.tmpfolder in the projectcli.pyandconvert.py