New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support template for email subject #147
Conversation
CI Build is failing on some test case not updated and affected by my code. See below --
|
Fix failing test case for inline CSS(less)
It would be useful as my current project requires "subject" to be of different language. But "subject" is not part of the template. I can make |
@gilbertwyw - thanks ! Most of the time we need to customise subject with same data (variables) as the body - so it does make sense to use the same template system for both cases. |
…ty. I first created a pull request on the original repository, but pull requests is not even getting reviewed there.
Can you please rebase into one commit? |
I would really appreciate this feature as well :) |
Okay, let me rebase and resubmit. Pull request kept waiting for months, and then I stopped following. |
@snow01 Any update on this :) ? |
Hey @ebourmalo, @niftylettuce -- As there were some changes in upstream, created a new pull request: #164 Hope to see this getting merged soon. Will discard this pull request. |
We often need template support for email subject too.