Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support template for email subject #147

Closed
wants to merge 10 commits into from
Closed

Support template for email subject #147

wants to merge 10 commits into from

Conversation

snow01
Copy link
Contributor

@snow01 snow01 commented Sep 27, 2015

We often need template support for email subject too.

@snow01
Copy link
Contributor Author

snow01 commented Sep 28, 2015

CI Build is failing on some test case not updated and affected by my code. See below --

1) Email templates should render html(jade) with inline CSS(less):
      Uncaught AssertionError: expected '<h4 style="color: #ccc;">test</h4>' to equal '<h4 style="color: #cccccc;">test</h4>'
      + expected - actual
      -<h4 style="color: #ccc;">test</h4>
      +<h4 style="color: #cccccc;">test</h4>

@gilbertwyw
Copy link

It would be useful as my current project requires "subject" to be of different language. But "subject" is not part of the template. I can make email-template package lookup different language folder that contain a meta data file. But this PR solves the problem much better.

@snow01
Copy link
Contributor Author

snow01 commented Sep 30, 2015

@gilbertwyw - thanks !

Most of the time we need to customise subject with same data (variables) as the body - so it does make sense to use the same template system for both cases.

@niftylettuce
Copy link
Collaborator

Can you please rebase into one commit?

@ebourmalo
Copy link

I would really appreciate this feature as well :)

@snow01
Copy link
Contributor Author

snow01 commented Mar 21, 2016

Okay, let me rebase and resubmit. Pull request kept waiting for months, and then I stopped following.

@ebourmalo
Copy link

@snow01 Any update on this :) ?

@snow01
Copy link
Contributor Author

snow01 commented Mar 26, 2016

Hey @ebourmalo, @niftylettuce --

As there were some changes in upstream, created a new pull request: #164

Hope to see this getting merged soon.

Will discard this pull request.

@snow01 snow01 closed this Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants