Pointer alignment

[xhernandez]

We currently align pointers to the right (just before the variable name) like this:

void *ptr;

This is achieved by PointerAlignment: Right in .clang-format.

However this has an incompatibility with another option we commonly use:

AlignConsecutiveDeclarations: true

With these options we get this:

void
test_function(void *arg)
{
    int32_t num;
    void *  ptr;
}

So the pointer is not correctly aligned on declarations. We can live with this or change one of the options.

With AlignConsecutiveDeclarations: false:

void
test_function(void *arg)
{
    int32_t num;
    void *ptr;
}

With PointerAlignment: Middle:

void
test_function(void * arg)
{
    int32_t num;
    void *  ptr;
}

With PointerAlignment: Left:

void
test_function(void* arg)
{
    int32_t num;
    void*   ptr;
}

@aravindavk @nigelbabu @amarts @jdarcy

[aravindavk]

Space after pointer looks odd. AlignConsecutiveDeclarations: false looks good to me.

PointerAlignment: Right
AlignConsecutiveDeclarations: false

[aravindavk]

https://stackoverflow.com/questions/38392889/clang-format-align-asterisk-of-pointer-declaration-with-variable-name

[xhernandez]

I Added a PR #10 to change the declarations alignment and escaped new lines alignment.