Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will this extension die after FF57? #16

Open
jjdelc opened this issue May 3, 2017 · 8 comments
Open

Will this extension die after FF57? #16

jjdelc opened this issue May 3, 2017 · 8 comments

Comments

@jjdelc
Copy link

jjdelc commented May 3, 2017

This extension is marked as Legacy in Firefox nightly, which means that it won't be compatible once FF57 launches.

Are there plans to make this into a Web extension?

@nigelbabu
Copy link
Owner

I would very much like to. I'm reaching out to the community to see if it's possible.

@aaronraimist
Copy link

I am working on converting this add-on to use WebExtensions but I am running into the issue of not knowing how to replace the use of the chrome module used by this add-on to quit the browser. I've uploaded what I have so far to my fork. Right now it does successfully prevent the browser from quitting at least on Mac but without something to replace that API I'm not sure how to finish it. I'll ask for some help in the Mozilla IRC channels tomorrow.

One difference between this new version and the old version is that panels now must be attached to a button in the toolbar. Since that didn't really seem to make sense for this add-on I had to use notifications to replace the panel in the middle of the screen. That seems to work fine but it is a change.

@justdave
Copy link

57 is now in the hands of developers and people who live on the edge with Nightly. It'll be in beta before too long. How's the progress on this? :-)

@nigelbabu
Copy link
Owner

From what I know, it's just about impossible to convert this extension to webextensions. I don't get access to shutdown the browser with this one :(

@fastcat
Copy link

fastcat commented Nov 1, 2017

@aaronraimist it looks like your fork is a good start ... but it also looks like it will only prevent one Ctrl-Q per launch? Perhaps it would make sense to track when the user tried to hit Ctrl-Q, and suppress the quit if it's either the first press this launch, or if it hasn't been pressed in the last N seconds, where default N would be somewhere in the 5-10 second range (something close to the notification fade-out time?), and maybe user configurable eventually?

IMO, the notification popup is a fine workaround for not being able to do the chrome module any more, so long as it gets dismissed automatically instead of requiring a user click like some notifications do.

@mjpieters
Copy link

An alternative extension, https://addons.mozilla.org/en-US/firefox/addon/disable-ctrl-q-and-cmd-q/, simply disables the Cmd-Q shortcut. This is good enough for my needs.

@aaronraimist
Copy link

Warn on quit is now build in to the browser in about:preferences

Screen Shot 2019-12-05 at 11 06 56 AM

@fastcat
Copy link

fastcat commented Dec 5, 2019

That toggle is useful, but not a full replacement for what this extension used to provide:

  • It doesn't do anything unless the Restore previous session is enabled
  • It ignores pinned tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants