Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture in Picture #3724

Closed
Rikunda opened this issue Jan 18, 2020 · 8 comments · Fixed by #3727
Closed

Picture in Picture #3724

Rikunda opened this issue Jan 18, 2020 · 8 comments · Fixed by #3727

Comments

@Rikunda
Copy link

Rikunda commented Jan 18, 2020

I cannot disable it, and the button ends up exactly where "Fullscreen" was. Can we get an option to disable this "feature"?

@Nareese
Copy link
Contributor

Nareese commented Jan 18, 2020

IMO, the better solution here is not to provide an option to disable it, but simply move the button to the other end of that button row, to the left of the settings cog, instead of to the right of fullscreen, breaking people's UX familiarity.

In the interim, you can install a CSS override extension like Stylus if you don't already have it, create a new ruleset for www.twitch.tv and add the following rule to it:

#bttv-picture-in-picture {
    display: none !important;
}

@Rikunda
Copy link
Author

Rikunda commented Jan 18, 2020 via email

@Nareese
Copy link
Contributor

Nareese commented Jan 18, 2020

Historically, night has been leery of "option clutter"... if there is no downside or the vast majority of people would never need or want to disable something, it doesn't need an option making the settings screen even more cluttered than it already is. The only reason why someone would need to disable this feature is because it's current positioning breaks a long established UX for where the fullscreen button should be. If the button is moved somewhere that it doesn't break people's UX habits, there is really no need to disable it... if you don't want to use the feature, just ignore the button. If you really want to completely disable it (presumably permanently), feel free to use the workaround above.

There is a long standing intention to someday redo the settings screen and options handling, to allow for a greater variety of settings customization than just simple on/off, and also to allow settings to be grouped and categorized, which will help with the clutter. If and when that redo ever happens, then the environment may be better to allow for more things to have options settings.

Obviously, I don't speak for night or for the project officially in any way, so he may feel differently in this case, and be willing to implement such an option... but I wouldn't bet on it, and hence why I supplied the workaround until the positioning can be fixed.

@schoerg
Copy link

schoerg commented Jan 19, 2020

@Nareese

The main issue as I see it is that muscle memory betrays you now. Fullscreen is probably the most used button in that list and the placement on the far right is only logical.

Another problem: if you enable PIP and then go fullscreen, the PIP window will stay and the main window will be black.

@Nareese
Copy link
Contributor

Nareese commented Jan 19, 2020

Of course. The current positioning is definitely a UX issue and needs addressing. I was just commenting on the issue having an option to disable it. Until the positioning is dealt with, people can use the Stylus workaround above to hide the button.

@Tinchox17
Copy link

any news on this?

is really annoying clicking the picture in picture by accident everytime.

@whitecrownclown
Copy link
Contributor

@Tinchox17 There is a PR open for changes on this. We're waiting on a review from the owner.

night pushed a commit that referenced this issue Feb 7, 2020
whitecrownclown added a commit to whitecrownclown/BetterTTV that referenced this issue Sep 4, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related issues or feature requests.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants