Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding whispers doesn't remove the space under the video player in theatre mode #3658

Closed
Tichael opened this issue Nov 24, 2019 · 2 comments
Closed
Labels

Comments

@Tichael
Copy link
Contributor

Tichael commented Nov 24, 2019

Summary

When hiding whispers, the space under the video player in theatre mode doesn't disappear anymore. The CSS rule in src/modules/conversations/style.css needs to be updated to reflect the new class name and DOM (apply the bottom: 0rem; to .highwind-video-player__container--theatre).

Detail story

When hiding whispers, I was thinking why the spare space under the video player in theatre mode wouldn't be removed. I though about suggesting the idea, but before doing that I took a look at the code. I found out that it was already present in the CSS file, but the class name of the player is wrong and the DOM has changed a little (Twitch probably changed it).

It's now .highwind-video-player__container--theatre directly. The bottom: 0rem; is still valid.

@Kaisirak
Copy link

This issue has surfaced again.

And .video-player__container--theatre-whispers is set to 4rem instead of 0rem

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related issues or feature requests.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants