Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine a solution for embedded data so it doesn't make the NuGet package grow exponentially per target framework #16

Closed
NightOwl888 opened this issue Sep 30, 2019 · 0 comments · Fixed by #38
Labels
is:enhancement New feature or request pri:low up for grabs This issue is open to be worked on by anyone

Comments

@NightOwl888
Copy link
Owner

If the data were somehow embedded in a shared assembly, we wouldn't need to have duplicates of the data inside each framework targeted binary. Instead of:

ICU4N.dll (net45 > 12MB)
ICU4N.dll (netstandard1.3 > 12MB)
ICU4N.dll (netstandard2.0 > 12MB)

We could have something like

ICU4N.dll (net45 > 1MB)
ICU4N.dll (netstandard1.3 > 1MB)
ICU4N.dll (netstandard2.0 > 1MB)

Data.dll (netstandard1.0 > 11MB)

Which scales much better for new target frameworks and saves tons of disk space. However, it is unclear what the best means of accomplishing that is, whether the DLL can/should be embedded into the NuGet package is a bit unclear.

Note also that using the name ICU4N.Resources.dll for the assembly name is not possible because .Resources.dll is reserved for another purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:enhancement New feature or request pri:low up for grabs This issue is open to be worked on by anyone
Projects
None yet
1 participant