Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Care portal temp target proposes 80 for Eating Soon, when server is in mmol mode #2093

Closed
PieterGit opened this issue Oct 15, 2016 · 6 comments
Milestone

Comments

@PieterGit
Copy link
Contributor

PieterGit commented Oct 15, 2016

When I set a temp target it proposes 80

image

which is fine in mg/dL mode, but I would assume that when you have your server in mmol mode it would propose 4.5 mmol/l


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@PieterGit PieterGit changed the title Care portal temp target proposes 80, when server is in mmol mode Care portal temp target proposes 80 for Eating Soon, when server is in mmol mode Oct 15, 2016
@PieterGit
Copy link
Contributor Author

The targets don't accept mmol values, and make the cell red:

image

The corresponding tooltip also does not use mmol mode

image

@jasoncalabrese
Copy link
Member

I was thinking of a way to customize the temp targets, maybe we can combine that with mmol support. I think we'll need to store the treatment with mg/dl values since that's what oref0 will expect

@ELUTE
Copy link
Contributor

ELUTE commented Feb 26, 2017

+1, I have this issue as well

@PieterGit PieterGit added this to the 0.10.3 milestone Jul 11, 2018
@PieterGit
Copy link
Contributor Author

@sulkaharo fixed this with #3670
I can confirm that it works. This will be released with Nightscout 0.10.3 release.

@ELUTE : please give latest dev branch a try to help testing this next Nightscout release.

@sulkaharo
Copy link
Member

Let’s create a separate ticket for configurability

@d3xr
Copy link

d3xr commented Jul 28, 2018

Is it work now? Temp target in mg/dl is terrible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants