Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongo_url_parser is super old and doesn't line up with the mongo driver, and rejects MaxIdleTimeMS when it shouldn't #7598

Closed
shanselman opened this issue Oct 7, 2022 · 4 comments

Comments

@shanselman
Copy link
Contributor

Describe the bug

mongo_url_parser is super old and doesn't line up with the mongo driver, and rejects MaxIdleTimeMS when it shouldn't

To Reproduce

use a connection string that includes MaxIdleTimeMS. NS will fail to start. Y'all need to update mongo url parser to MATCH the mongo driver.

image

@sulkaharo
Copy link
Member

@bewest see linked PR that bumps the URL parser version to include the version that supports the parameter Scott is having issues with

@bjornoleh
Copy link
Contributor

I can confirm #7606 works for me when testing with maxIdleTimeMS=120000, instead of socketTimeoutMS=120000 as suggested by Scott as a workaround in his Azure setup video:
https://www.youtube.com/watch?v=EDADrteGBnY&ab_channel=ScottHanselman

@bjornoleh
Copy link
Contributor

However, https://github.com/nightscout/cgm-remote-monitor/tree/update-mongo-url-parser does not deploy to Heroku. Deploying to Azure using Docker works, but not deploy from GitHub to Heroku.

Heroku build log:

-----> Building on the Heroku-22 stack
-----> Using buildpack: heroku/nodejs
-----> Node.js app detected
       
-----> Creating runtime environment
       
       NPM_CONFIG_LOGLEVEL=error
       NODE_VERBOSE=false
       NODE_ENV=production
       NODE_MODULES_CACHE=true
       
-----> Installing binaries
       engines.node (package.json):  ^16.x || ^14.x
       engines.npm (package.json):   unspecified (use default)
       
       Resolving node version ^16.x || ^14.x...
       Downloading and installing node 16.18.0...
       Using default npm version: 8.19.2
       
-----> Restoring cache
       - npm cache
       
-----> Installing dependencies
       Installing node modules
       npm ERR! code EBADPLATFORM
       npm ERR! notsup Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin"} (current: {"os":"linux","arch":"x64"})
       npm ERR! notsup Valid OS:    darwin
       npm ERR! notsup Valid Arch:  undefined
       npm ERR! notsup Actual OS:   linux
       npm ERR! notsup Actual Arch: x64
       
       npm ERR! A complete log of this run can be found in:
       npm ERR!     /tmp/npmcache.vzhHf/_logs/2022-10-24T14_40_53_299Z-debug-0.log
-----> Build failed
       
       We're sorry this build is failing! You can troubleshoot common issues here:
       https://devcenter.heroku.com/articles/troubleshooting-node-deploys
       
       If you're stuck, please submit a ticket so we can help:
       https://help.heroku.com/
       
       Love,
       Heroku
       
 !     Push rejected, failed to compile Node.js app.
 !     Push failed

@bewest @shanselman @sulkaharo

@sulkaharo
Copy link
Member

sulkaharo commented Jan 27, 2023

Dev finally has the updated version (and a lock file that deploys to Heroku)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants