static lib and dynamic lib shouldn't be duplicate cmake targets

[johnb003]

the cmake file for libraries is meant just to define how things are related, then you rely on the compiler to interpret those and put them together.

Static libs and shared libs can be built with pretty much the same definition of relationships.

The preferred way of doing it is: add_library(target sources), without STATIC or SHARED, thus relying on whatever is specified in BUILD_SHARED_LIBS to determine it. See https://cgold.readthedocs.io/en/latest/tutorials/libraries/static-shared.html

[0-wiz-0]

Which CMakeLists.txt file and which part do you mean? I don't understand.

[johnb003]

Never mind, I might have written this after reading the PR that was never merged ><