Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace jinja2 templates with python html generation #23

Open
nihlaeth opened this issue May 10, 2017 · 1 comment
Open

replace jinja2 templates with python html generation #23

nihlaeth opened this issue May 10, 2017 · 1 comment

Comments

@nihlaeth
Copy link
Owner

Problems

  • too much code duplication
  • too much nesting
  • mistakes in bootstrap syntax
  • messy HTML
  • don't have any HTML grammars for my speech recognition

The last one is easily solved, but I much prefer working in Python anyway. I'm currently in the process of writing an abstraction interface on top of pyhtml and replacing our current templates. It's already paying off, because I've caught several syntax errors. Hopefully it will in time prove to be easier to extend on top of this.

@nihlaeth nihlaeth created this issue from a note in basic functionality (refactor) May 10, 2017
@nihlaeth nihlaeth self-assigned this May 10, 2017
@nihlaeth
Copy link
Owner Author

nihlaeth commented May 11, 2017

Progress replacing templates

  • index page
  • actions
  • general
  • combat
  • skills
  • prayers
  • spells
  • powers
  • inventory
  • background

@nihlaeth nihlaeth added this to to_do in pyhtml May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
pyhtml
to_do
Development

No branches or pull requests

1 participant