Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credential disclosure in logs #17

Closed
joe-bowman opened this issue Oct 28, 2019 · 2 comments
Closed

Credential disclosure in logs #17

joe-bowman opened this issue Oct 28, 2019 · 2 comments

Comments

@joe-bowman
Copy link

If forwarding queries on to a server requiring authentication, if URL is of the form http://username:password@localhost:8123, these credentials are disclosed in the log file by

clickhouse-bulk/clickhouse.go

Line 182 in 4f084dd

log.Printf("INFO: send %+v rows to %+v of %+v\n", r.Count, url, r.Query)

We should redact the password portion of this string before echoing it.
@nikepan
Copy link
Owner

nikepan commented Oct 28, 2019

oh. thanks. I'll fix it tomorrow

@nikepan
Copy link
Owner

nikepan commented Oct 29, 2019

fixed https://github.com/nikepan/clickhouse-bulk/releases/tag/v1.2.2 - log only server url

@nikepan nikepan closed this as completed Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikepan @joe-bowman