Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectTimeout option is not tend to work properly #28

Closed
Mixser opened this issue Apr 30, 2020 · 2 comments
Closed

ConnectTimeout option is not tend to work properly #28

Mixser opened this issue Apr 30, 2020 · 2 comments

Comments

@Mixser
Copy link

Mixser commented Apr 30, 2020

Hi,

At NewClickhouse method your have been implemented not right behavior for the ConnectTimeout options:

c.ConnectTimeout = connectTimeout
if c.ConnectTimeout > 0 {
    c.ConnectTimeout = 10
}

So, if I will set any positive value for ConnectTimeout - it will be not used but rewritten to 10 seconds;

@nikepan
Copy link
Owner

nikepan commented May 2, 2020

Oh, thanks!

@nikepan
Copy link
Owner

nikepan commented May 2, 2020

I fixed it in release v1.2.6

@Mixser Mixser closed this as completed May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants