Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Some HTML <pre> elements missing in epub when converting from url #23

Open
cykirk opened this issue Nov 28, 2022 · 2 comments
Open

Comments

@cykirk
Copy link

cykirk commented Nov 28, 2022

Describe the bug
Some, but not all, pre elements don't appear in final epub.

To Reproduce
Steps to reproduce the behavior:

  1. Use kindle-send to download bash reference manual
    kindle-send -url https://www.gnu.org/savannah-checkouts/gnu/bash/manual/bash.html
  2. Inspect epub file section 'Creating Internationalized Scripts' and see that some code snippets are missing.

Expected behavior
All code snips should be rendered.

Screenshots
kindlesendissue

@cykirk
Copy link
Author

cykirk commented Nov 28, 2022

Seems like this might be an issue in the go-epub library as I had the same issue when using papeer

@nikhil1raghav
Copy link
Owner

Issue is with readability, project uses go-readability which is port of mozilla's readability. When you open the same page in firefox reader mode then also that snippet is missing. Need to patch go-readability for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants