StringBuilder and empty string handling

nikhilk · May 29, 2012 · ae47e50 · ae47e50
1 parent 7949d0c
commit ae47e50
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/Client/Runtime/Base/BCL.js b/src/Client/Runtime/Base/BCL.js
@@ -9,12 +9,12 @@ function Tuple(first, second, third) {
 }
 
 function StringBuilder(s) {
-  this._parts = isValue(s) ? [s] : [];
+  this._parts = isValue(s) && s !== '' ? [s] : [];
   this.isEmpty = this._parts.length == 0;
 }
 var StringBuilder$proto = {
   append: function(s) {
-    if (isValue(s)) {
+    if (isValue(s) && s !== '') {
       this._parts.push(s);
       this.isEmpty = false;
     }

diff --git a/tests/Client/Runtime/Core/StringBuilder.htm b/tests/Client/Runtime/Core/StringBuilder.htm
@@ -79,6 +79,24 @@ <h2 id="qunit-userAgent"></h2>
     sb.append([1,2]);
     QUnit.equal(sb.toString(':'), 'abc:123:true:false:1,2');
   });
+
+  test('isEmpty', function() {
+    var sb = new ss.StringBuilder();
+    QUnit.equal(sb.isEmpty, true);
+
+    sb.append('');
+    QUnit.equal(sb.isEmpty, true);
+
+    sb.append(null);
+    QUnit.equal(sb.isEmpty, true);
+
+    sb.append(undefined);
+    QUnit.equal(sb.isEmpty, true);
+
+    sb.append(0);
+    QUnit.equal(sb.isEmpty, false);
+    QUnit.equal(sb.toString(), '0');
+  });
   </script>
 </body>