Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Allowed Countries messing up the package #20

Closed
jainarihant opened this issue Dec 18, 2018 · 6 comments
Closed

Problem with Allowed Countries messing up the package #20

jainarihant opened this issue Dec 18, 2018 · 6 comments

Comments

@jainarihant
Copy link
Contributor

jainarihant commented Dec 18, 2018

I am using:
"@angular/animations": "^4.4.7",
"@angular/cdk": "^5.2.5",
"@angular/cli": "^1.7.4",
"@angular/common": "^5.2.11",
"@angular/compiler": "^5.2.11",
"@angular/compiler-cli": "^5.2.11",
"@angular/core": "^5.2.11",
"@angular/forms": "^5.2.11",
"@angular/http": "^5.2.11",
"@angular/language-service": "^5.2.11",
"@angular/material": "^5.2.5",
"@angular/platform-browser": "^5.2.11",
"@angular/platform-browser-dynamic": "^5.2.11",
"@angular/router": "^5.2.11"

And the current version of "ngx-international-phone-number": "~1.0.1", I require https resources for the flags so I am using this new version.
The package gets installed properly, but when I run my angular app I get this:
ERROR in node_modules/ngx-international-phone-number/phone-number.component.d.ts(13,23): error TS1122: A tuple type element list cannot be empty.

I dug a bit on this and found that variable allowedCountries: [ ] has been wrongly type-casted in the build. It should have been allowedCountries: Country[ ].

I'll try to put up a PR for this.

@ronrumao
Copy link

@nikhiln if you provide me with the access to create branch and open a PR, maybe I'll raise a PR for the same issue.

@nikhiln
Copy link
Owner

nikhiln commented Dec 18, 2018

@ronrumao @jainarihant You guys should be able to fork and open up PR.

@jainarihant
Copy link
Contributor Author

jainarihant commented Dec 18, 2018

@nikhiln PR raised #21 .

@jainarihant
Copy link
Contributor Author

Fixed in #21

@ronrumao
Copy link

ronrumao commented Jan 2, 2019

@nikhiln the changes related to #21 are merged but not published yet.
Is there any need to bump version or manually publish the changes? As the version in the npm repository is 1.0.1 and is published 21 days ago( which is older than #21 changes)

@vitorolivg
Copy link

vitorolivg commented Jan 23, 2019

@nikhiln I have created a PR (#26) to the right package version, could you please publish it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants