Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the best model selection #26

Closed
catherine-qian opened this issue Mar 15, 2022 · 2 comments
Closed

the best model selection #26

catherine-qian opened this issue Mar 15, 2022 · 2 comments

Comments

@catherine-qian
Copy link

Dear authors,

Could you please let me know how you select the best model?
From the validation set? or report the best test results in the paper?

BTW, have you tried to remove the adversarial scheme to see the results with only a generator?

@nikhilsinghmus
Copy link
Owner

Hi! Yes, we just used test set performance as in the paper. We didn’t do early stopping or similar, generally.

Early on we had tried a non-adversarial approach but found it difficult to get good results so didn’t include it in the ablations later, if I remember correctly. Could definitely be worth revisiting though, because we did make other improvements since then.

@catherine-qian
Copy link
Author

thanks for the prompt reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants