Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to inject RouteCollector into simpleDispatcher #40

Closed
msheakoski opened this issue Apr 3, 2015 · 2 comments
Closed

Add ability to inject RouteCollector into simpleDispatcher #40

msheakoski opened this issue Apr 3, 2015 · 2 comments

Comments

@msheakoski
Copy link

I extended RouteCollector to do some pre-processing on the route definitions before adding them and when trying to use simpleDispatcher, I discovered that I needed to duplicate that code because FastRoute\RouteCollector is a hard-wired dependency.

What do you think about adding "routeCollector" => "FastRoute\\RouteCollector" to the $options array in simpleDispatcher? It would be a backwards compatible change but add the ability to inject a custom RouteCollector.

@nikic nikic closed this as completed in 77a51ea Apr 3, 2015
@nikic
Copy link
Owner

nikic commented Apr 3, 2015

Done :)

@msheakoski
Copy link
Author

Thank you! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants