Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of using the same parameter more than once has been added. #3

Merged
merged 6 commits into from Apr 3, 2019

Conversation

bronweg
Copy link
Contributor

@bronweg bronweg commented Mar 26, 2019

Possibility of using the same parameter more than once has been added.

@nikita-skobov
Copy link
Owner

Looks good, thank you. Now that there are a few more options, ie: asterisk, plus sign, minus sign, I think It will be better if they are all placed at the end of the argument list. So the asterisk comes in the beginning, and the plus sign, minus sign come at the end of the variable name. I will be making a pull request later to change that.

@nikita-skobov nikita-skobov merged commit 1ff4722 into nikita-skobov:master Apr 3, 2019
@nikita-skobov
Copy link
Owner

Actually now that I think about it, maybe that's not a good idea because users could do something like:

--arguments *file+

which makes file a required argument that can be used multiple times, and the logic works fine for that,
but if we switched to this:

--arguments file+*

the program would need to also handle

-- arguments file*+

So I think it's better to keep it working as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants