Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implementing an OID-based decoder compatibility check #97

Open
nikita-volkov opened this issue Aug 31, 2018 · 6 comments
Open

Comments

@nikita-volkov
Copy link
Owner

No description provided.

@ocharles
Copy link

postgresql-simple does this, which you might want to use for reference.

@nikita-volkov
Copy link
Owner Author

The only usefulness of that would be in catching only a portion of possible errors and doing so in runtime. To me the benefit of that seems arguable.

@ocharles
Copy link

Personally I take the philosophy that most bugs lie at the boundaries of systems, and hasql is precisely there to interface between two systems. This is where a lot of error checking should be done, so I'd be in favour of doing this check.

@nikita-volkov
Copy link
Owner Author

I agree. However implementation-wise, it's gonna take some effort. I'll schedule doing this in the libpq-free version

@bergey
Copy link

bergey commented Jun 28, 2019

Do you think checking the type info is easier if you bypass libpq? Or is your schedule just about prioritization?

@nikita-volkov
Copy link
Owner Author

Do you think checking the type info is easier if you bypass libpq?

No. It's perfectly possible to get this data thru libpq. And I would accept a PR implementing this.

Or is your schedule just about prioritization?

It is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants