Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit status 1 for dotfile #9

Closed
bowernite opened this issue Dec 17, 2020 · 3 comments · Fixed by #11
Closed

Exit status 1 for dotfile #9

bowernite opened this issue Dec 17, 2020 · 3 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@bowernite
Copy link
Contributor

To reproduce

  1. Make change to file with path .zshrc (i.e., in root of git repo)
  2. $ gitupdate

Result:

2020/12/16 19:09:56 exit status 1
@bowernite bowernite added the bug Something isn't working label Dec 17, 2020
@nikitavoloboev
Copy link
Owner

I need to add some error catching. Not sure what caused this error to happen. The command will essentially git add ., git commit -m .. (with file names) and git push.

If you try run it yourself and see if any of the commands throws error, you will know the cause. Sometimes it's due to git .lock file being present.

@bowernite
Copy link
Contributor Author

I think the problem is the logic here, where it's trying to strip the filename extension. For a file that starts with . like .zshrc, there's going to be nothing left for that part of the commit message, which is what I would imagine is causing the problem.

Not sure on the solution -- maybe just strip any leading periods off of filenames before doing that logic.

Happy to submit a PR at some point, but to be honest I have no idea what I'm doing in Go and might not have time soon to learn it.

@nikitavoloboev
Copy link
Owner

I'll try it out, thanks. Go is simple (https://news.ycombinator.com/item?id=25646909).

I'll try fix this soonish, if not, I am open to PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants