Unable to use lists inside slides

[bsilva98]

Hello -- first contact, so let me just say that this is a fabulous widget!

For the bug: I am placing regular HTML inside slides, and it works great until I put a list into it. Then it miscalculates the width of the slides. I narrowed it down to line 41 in the code, and just as a suggestion, using this fixes it:

$slides = $accordion.children('ol', 'ul').children('li')

Thanks!

[bandrzej]

There is actually an easier fix for line 41:
$slides = $accordion.find('ol > li:not(li > li)'),

This will avoid any sub li's within each slide being to calculate slide width.

[nikki]

Thanks guys, I'll get this fixed asap.

[bsilva98]

Great, thanks a bunch!

On 28 Jul 2011, at 20:01, nikki wrote:

Thanks guys, I'll get this fixed asap.

Reply to this email directly or view it on GitHub:
#17 (comment)

[SpoonIsBad]

Thanks! My whole site is basically based around your accordion, awesome work!

[isleshocky77]

I had written the following fix for line 41 and then found this bug up here. When trying to use the two recommended fixes, none of them worked for my purposes. Figured I'd throw mine up in case it is of help to anyone else.

      $slides = $accordion.find('> ul > li, > ol > li'),

[nikki]

Thanks isleshocky77,

If anyones having major problems with this, it's safe to use the dev version. There's only a couple of theme related issues to work through before I release it as version 2.

Thanks,
Nikki.

[nikki]

Should be fixed in v2.

Thanks!
Nikki.

[bsilva98]

Thanks Nikki!

On 16 Nov 2011, at 04:54, nikki wrote:

Should be fixed in v2.

Thanks!
Nikki.

---

Reply to this email directly or view it on GitHub:
#17 (comment)