Skip to content
This repository has been archived by the owner on Apr 9, 2019. It is now read-only.

Selector options #24

Closed
thugsb opened this issue Oct 4, 2011 · 3 comments
Closed

Selector options #24

thugsb opened this issue Oct 4, 2011 · 3 comments

Comments

@thugsb
Copy link

thugsb commented Oct 4, 2011

It would be nice to be able to specify the selectors, rather than relying on a particular HTML structure. So something like this as the defaults:

{
slideEl : $(this).children('li'),
headerEl : $(this).find('h2'),
contentEl : $(this).children('li').children('div')
}

Also, I'm not sure why you need the DIV around the OL. Could the default structure not just be the following?
ol
-li
--h2
--div

@nikki
Copy link
Owner

nikki commented Oct 4, 2011

It would be nice to be able to specify the selectors, rather than relying on a particular HTML structure. So something like > this as the defaults:

{
slideEl : $(this).children('li'),
headerEl : $(this).find('h2'),
contentEl : $(this).children('li').children('div')
}

I can't think of any other structures that would make sense (semantically) in this context?

Also, I'm not sure why you need the DIV around the OL. Could the default structure not just be the following?
ol
-li
--h2
--div

I need the div as an extra hook for css styles. Plus I like the way it neatly encapsulates everything.

@thugsb
Copy link
Author

thugsb commented Oct 4, 2011

For the selectors, I'm trying to implement code that's generated from a CMS. I have an extra DIV inside my LIs before I get the H2 and content DIV.

Also, H2 may not always be appropriate. My content is less valuable, and I'd prefer to make it a H4.

Flexibility is always good, and I don't think it would be much more work. It just opens up options. Just because you and I can't think of other semantic structures, doesn't mean they don't exist.

@nikki nikki closed this as completed Oct 4, 2011
@nikki
Copy link
Owner

nikki commented Oct 4, 2011

Thanks for your feature request, but I won't be implementing it at this time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants