Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving a draft PR to review column should mark it as ready for review #116

Open
1 task
nikku opened this issue Mar 19, 2021 · 0 comments · May be fixed by #124
Open
1 task

Moving a draft PR to review column should mark it as ready for review #116

nikku opened this issue Mar 19, 2021 · 0 comments · May be fixed by #124
Assignees
@nikku
Labels
backlog blocked enhancement New feature or request

Comments

@nikku
Copy link
Owner

nikku commented Mar 19, 2021 •
edited

Is your feature request related to a problem? Please describe

Given our tight integration with GitHub flow, I'd expect draft PRs to automatically be converted to a "ready for review" PR if the user moves it to the review column. This is my intend as a user.

Describe the solution you'd like

  • Draft PRs is converted to a "ready for review" PR if the user moves it to the review column.

Describe alternatives you've considered

None.

Additional context

Not working in wuffle@0.41.1.

Blocked by GitHub limitations: It is currently not possible to use the GraphQL v4 mutations convert to draft as well as mark ready for review from GitHub apps with user scope (cf. allowed user to server requests).

Will be closed via #124 once support for the mutations from GitHub apps lands on GitHub side.
@nikku nikku added the enhancement New feature or request label Mar 19, 2021
@nikku nikku added the backlog label May 13, 2021
@nikku nikku added the roadmap This issue is scope of the mid-term roadmap label Sep 19, 2021
@nikku nikku mentioned this issue Oct 24, 2021
Closed
@nikku nikku linked a pull request Nov 13, 2021 that will close this issue
Draft
@nikku nikku added the blocked label Nov 17, 2021
@wuffle-test-app wuffle-test-app bot added needs review in progress and removed backlog roadmap This issue is scope of the mid-term roadmap needs review labels Mar 13, 2022
@nikku nikku added backlog and removed in progress labels Mar 13, 2022
@nikku nikku self-assigned this Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
backlog blocked enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert to draft and back again nikku/wuffle
1 participant
@nikku