Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder of Issues in Inbox column reopens linked closed issues #45

Closed
joannenolan-sky opened this issue Jul 31, 2019 · 7 comments
Closed
Labels
invalid This doesn't seem right

Comments

@joannenolan-sky
Copy link
Contributor

When reordering issues in my Inbox column, the issue order is updated but all the closed linked issues and Pull requests are reopened. This is currently seen against version 17. I will be updating today to the latest version but it seems it was possibly introduced when the issues ordering was changed in version 15.

@nikku
Copy link
Owner

nikku commented Jul 31, 2019

Could you provide me with some steps to reproduce this issue? Best would be a test case for the store.

A good place to add it is probably here.

@nikku
Copy link
Owner

nikku commented Jul 31, 2019

It is most likely due to this line. The question is, what kind of relationships you use and why it is being interpreted by the board like this.

@joannenolan-sky
Copy link
Contributor Author

It seems to be only doing it to epics using parent of to link to children

@nikku
Copy link
Owner

nikku commented Aug 1, 2019

I've removed ordering of referenced issues via 260d1e8.

The idea was once to move issues with the PR. As it is right now, PRs are always attached to the issue and cannot be moved without the issue anyway. That means the respective piece of code was kinda pointless anyway.

Would still have been interesting to get the exact details on your case, as I cannot depict a sane scenario for which closed, linked issues should have automatically been reopened 😉.

@nikku nikku closed this as completed Aug 1, 2019
@nikku nikku added the invalid This doesn't seem right label Aug 1, 2019
@joannenolan-sky
Copy link
Contributor Author

I was able to replicate it locally and it was exactly in the line you referenced. As the moveReferencedIssues was called it set the linked issue column to be the same as the main issue so any closed issues/pr were reopend as when the getStateUpdate ran they were no longer in the closed column so their state was set to open.

@nikku
Copy link
Owner

nikku commented Aug 2, 2019

What was the exact issues you reproduced it with? I still don't know which relationships you wired. For future bug reports, this is crucial information:

  • Which card is being moved, what is it's old state, new state, title and body (defining links)
  • Which card is being affected, too, what is it's old state, new state, title and body (defining links)

@joannenolan-sky
Copy link
Contributor Author

joannenolan-sky commented Aug 2, 2019

Ok I was starting with the following issues as per screenshot

State befroe reorder

I moved issue 104 to the top of the backlog column above issue 109. When that happened issue 105 was moved to backlog and issue 107 was also moved to backlog and reopened as per screenshot

State after reorder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants