-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Straight optimization proposal #3
Comments
Will be fixed. Thanks! Create pull request next time. |
this way not the highest possible straight is returned but the lowest instead - will fix it |
Add unit tests (for regression) |
!!! line 134 - var straightCards = cards.Select(x => (int)x.Type).ToList(); - returns duplicates renaming proposal: CompareTwoHandsWithHighCard => CompareKickers/CompareSideCards Comparing straights - comparing any card[1-3] is enough - no Ace possible there - |
Open new issues for every single bug. |
When comparing straights there are objects of type |
Mean if compare e.g. 2nd cards only - no |
What about this case:
|
e.g. |
I've got the idea but the current solution is |
thought they come sorted from hand evaluator, from tests come shuffled - anyway U know better 👍 |
better list clear than new list - line 97
The text was updated successfully, but these errors were encountered: