Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for writing APIC tags #3

Closed
anoorally opened this issue May 6, 2019 · 9 comments
Closed

Example for writing APIC tags #3

anoorally opened this issue May 6, 2019 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@anoorally
Copy link

Can you please provide an example how an APIC tag can be written?

@NiKoTron
Copy link
Owner

NiKoTron commented May 9, 2019

Hello! So there is alreay in the tests test/dart_tags_test.dart

@anoorally
Copy link
Author

@NiKoTron Thank you for your reply.
I've applied your example code but its not working. I get the following:
Unhandled Exception: 'package:dart_tags/src/writers/id3v2.dart': Failed assertion: line 76 pos 12: 'value <= 9999': is not true.

Each frame can be 16 MB in size as quoted below:

Since each frame can be 16MB and the entire tag can be 256MB
(Source: http://id3.org/ID3v2Easy)

Can you please advise how to proceed?

@NiKoTron NiKoTron self-assigned this May 10, 2019
@NiKoTron
Copy link
Owner

So, it looks like a bug, I'm going to fix it as soon as possible. Thank you for the report.

@NiKoTron
Copy link
Owner

@anoorally I've increased the limit to 16MB. The error above shouldn't occur anymore.

@anoorally
Copy link
Author

@NiKoTron Thanks for the fix.
I've re-tested with the updated package. The error no longer occurs, but something is off about the image. The APIC image does not show, although the mp3 file plays (which means it is not corrupt).
Dumping the tags shows the APIC in Base64, but re-converting them to image shows blank.
Would you have any suggestions?

@NiKoTron
Copy link
Owner

Writers are currently available as an experimental feature. So.. it's could be happening at this time. Also while retesting I've found some other issues with id3v2 writer.

Currently, I focused to rewrite some inner logic for independent frame processing, and as a result, it should solve this problem. I guess I'll finish at the end of the week. This changes will not affect the library's API.

Thanx for using and reporting about issues.

Stay tuned.

@sriharsha-y
Copy link

Hey @NiKoTron , any update on this could not get the APIC thing working and images shows blank. Thanks for this great package.

NiKoTron added a commit that referenced this issue Jul 21, 2019
NiKoTron added a commit that referenced this issue Jul 21, 2019
@NiKoTron
Copy link
Owner

Hi! @anoorally @sriharsha-y Please update and check this test. It's writing a picture to mp3 then read it and generate image file and html file with base64 encoded img tag. Also, you could check resut.mp3 with tag readers. As a reference reader, I used MusicBrainz's picard.

@NiKoTron
Copy link
Owner

@anoorally @sriharsha-y, is it ok? could I close this issue?

@NiKoTron NiKoTron added the bug Something isn't working label Jul 30, 2019
@NiKoTron NiKoTron closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants