Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple ObserverModelInstanceMixin can't be used with multiple models within the same project #3

Closed
hishnash opened this issue Aug 18, 2018 · 0 comments
Closed

Multiple ObserverModelInstanceMixin can't be used with multiple models within the same project #3

hishnash opened this issue Aug 18, 2018 · 0 comments
Assignees
@hishnash
Labels
bug Something isn't working

Comments

@hishnash
Copy link
Member

GenericModelObserver is instantiated as a decorator of methods on ObserverModelInstanceMixin this means that once you have implemented one consumer with this mixin all others will use the same ModelCLS regardless of the queryset's model type.

This is a critical bug.
@hishnash hishnash added the bug Something isn't working label Aug 18, 2018
@hishnash hishnash self-assigned this Aug 18, 2018
@hishnash hishnash mentioned this issue Aug 18, 2018
Merged
hishnash added a commit that referenced this issue Aug 18, 2018
@hishnash
Merge pull request #4 from hishnash/3/ObserverModelInstanceMixin-fix
78b29b7 
[Fix #3] ObserverConsumerMixin support multiple subclasses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hishnash hishnash

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hishnash