New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User warning when data is being upsampled when masked #3397
Comments
we can improve the warning message but I like the idea! |
Actually now that I'm trying to write a check to catch the upsampling, I'm not so sure anymore that it's always the default behaviour. It for sure has happened to me but I might need to investigate deeper into how I got it to happen. |
I'm going to see this warning so often haha 😆 |
Hi @FrancoisPgm sorry it took me a while to get back to you. So the resampling to the mask is indeed the default behavior of the It is the case that the default behavior for the other maskers is different and they do not need this warning. |
@mtorabi59 can you also have a look at this? I think implementing this warning can only be helpful in the meantime while we haven't made a decision about making this behavior consistent across all maskers. |
@ymzayek sure, I will put it at the top of my list! |
The default beahaviour of maskers is to resample the data to the mask's affine, but when the data has a lower resolution than the mask, it upsamples the data, requiring more computation and memory than necessary. Throwing a warning when it happens could help users to specify a target affine when it is relevant.
Benefits to the change
Users can realise when they upsample their data, and that they can save computation time and memory by specifying a target affine (or a resampling strategy).
Pseudocode for the new behavior, if applicable
The text was updated successfully, but these errors were encountered: