Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a logger to "first_level_from_bids" #3686

Open
Remi-Gau opened this issue Apr 13, 2023 · 3 comments · May be fixed by #3702
Open

add a logger to "first_level_from_bids" #3686

Remi-Gau opened this issue Apr 13, 2023 · 3 comments · May be fixed by #3702
Labels
BIDS Effort: low The issue is likely to require a small amount of work (less than a few hours). GLM Issues/PRs related to the nilearn.glm module. Impact: low Solving this issue will have a small impact on the project. Priority: low The task is not urgent and can be delayed. User Experience

Comments

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Apr 13, 2023

I am having to pass this verbose parameter around a bit too much to be able to control whether warnings, messages should be printed...

This should probably be handled better by implementing a logger in another PR.

Originally posted by @Remi-Gau in #3605 (comment)

@jeromedockes
Copy link
Member

could you give a few more details on what implementing a logger would look like? the verbose parameter for estimators is used throughout nilearn and scikit-learn so it would have to stay, but I guess you mean changing how the verbosity level is controlled in private functions?

@Remi-Gau
Copy link
Collaborator Author

you mean changing how the verbosity level is controlled in private functions?

yes exactly: this would concern just the private functions that are specific to first_level_from_bids.
If it is calling another nilearn or sklearn function that has the usual verbose argument then it would be passed as usual.

if that helps to make things more concrete I can create a draft PR of how I would apply it to say one private function, you give me early feedback (as there may be future headaches that may follow from this that I have not foreseen) and then we decide whether this is worth pursuing further.

@jeromedockes
Copy link
Member

sounds like a good plan!

@Remi-Gau Remi-Gau linked a pull request Apr 18, 2023 that will close this issue
@Remi-Gau Remi-Gau added User Experience GLM Issues/PRs related to the nilearn.glm module. Impact: low Solving this issue will have a small impact on the project. Effort: low The issue is likely to require a small amount of work (less than a few hours). Priority: low The task is not urgent and can be delayed. labels Apr 19, 2023
@Remi-Gau Remi-Gau added the BIDS label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BIDS Effort: low The issue is likely to require a small amount of work (less than a few hours). GLM Issues/PRs related to the nilearn.glm module. Impact: low Solving this issue will have a small impact on the project. Priority: low The task is not urgent and can be delayed. User Experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants