New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Removed all mentions of "License" from headers #3838
Conversation
👋 @czarinasy Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3838 +/- ##
==========================================
+ Coverage 91.53% 91.57% +0.03%
==========================================
Files 133 133
Lines 15623 15616 -7
Branches 3250 3248 -2
==========================================
- Hits 14301 14300 -1
+ Misses 774 770 -4
+ Partials 548 546 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @czarinasy ! As a first time contributor you also need to add your name to CITATION.cff under authors in alphabetical order by first name.
Thanks for the tip @ymzayek! I've made the update now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rerunning the CI workflow that cancelled after 6 hours... 99.99999% sure it is unrelated to this but I just want to see how flaky this failure is. |
all green now merging thanks @czarinasy |
Closes #3771.
Changes proposed in this pull request: