Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Removed all mentions of "License" from headers #3838

Merged
merged 4 commits into from Jul 10, 2023

Conversation

czarinasy
Copy link
Contributor

Closes #3771.

Changes proposed in this pull request:

  • Removed the "License" comment from all listed headers

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

👋 @czarinasy Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@czarinasy czarinasy changed the title Removed all mentions of "License" from header as raised in issue #3771 [MAINT] Removed all mentions of "License" from header as raised in issue #3771 Jul 10, 2023
@czarinasy czarinasy changed the title [MAINT] Removed all mentions of "License" from header as raised in issue #3771 [WIP] Removed all mentions of "License" from header as raised in issue #3771 Jul 10, 2023
@czarinasy czarinasy changed the title [WIP] Removed all mentions of "License" from header as raised in issue #3771 [MAINT] Removed all mentions of "License" from headers Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #3838 (cc4db84) into main (01cfa3d) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3838      +/-   ##
==========================================
+ Coverage   91.53%   91.57%   +0.03%     
==========================================
  Files         133      133              
  Lines       15623    15616       -7     
  Branches     3250     3248       -2     
==========================================
- Hits        14301    14300       -1     
+ Misses        774      770       -4     
+ Partials      548      546       -2     
Flag Coverage Δ
macos-latest_3.10 91.49% <ø> (+0.03%) ⬆️
macos-latest_3.11 ?
macos-latest_3.8 91.46% <ø> (+0.03%) ⬆️
macos-latest_3.9 91.46% <ø> (+0.03%) ⬆️
ubuntu-latest_3.10 91.49% <ø> (+0.03%) ⬆️
ubuntu-latest_3.11 91.49% <ø> (+0.03%) ⬆️
ubuntu-latest_3.8 91.46% <ø> (+0.03%) ⬆️
ubuntu-latest_3.9 ?
windows-latest_3.10 91.43% <ø> (+0.03%) ⬆️
windows-latest_3.11 91.43% <ø> (+0.03%) ⬆️
windows-latest_3.8 91.40% <ø> (+0.03%) ⬆️
windows-latest_3.9 91.40% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nilearn/_utils/cache_mixin.py 80.64% <ø> (ø)
nilearn/_utils/extmath.py 89.47% <ø> (ø)
nilearn/_utils/logger.py 100.00% <ø> (ø)
nilearn/_utils/ndimage.py 88.88% <ø> (ø)
nilearn/_utils/niimg.py 97.11% <ø> (ø)
nilearn/_utils/niimg_conversions.py 90.47% <ø> (ø)
nilearn/_utils/numpy_conversions.py 96.00% <ø> (ø)
nilearn/_utils/testing.py 66.66% <ø> (ø)
nilearn/connectome/group_sparse_cov.py 81.58% <ø> (ø)
nilearn/datasets/neurovault.py 90.49% <ø> (ø)
... and 22 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @czarinasy ! As a first time contributor you also need to add your name to CITATION.cff under authors in alphabetical order by first name.

@czarinasy
Copy link
Contributor Author

Thanks for the tip @ymzayek! I've made the update now

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Remi-Gau
Copy link
Collaborator

Rerunning the CI workflow that cancelled after 6 hours... 99.99999% sure it is unrelated to this but I just want to see how flaky this failure is.

@Remi-Gau
Copy link
Collaborator

all green now

merging

thanks @czarinasy

@Remi-Gau Remi-Gau merged commit 4e2bd91 into nilearn:main Jul 10, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mention of license in "header" of *.py file
3 participants