Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

momentjs deprecated #72

Closed
mchangrh opened this issue Sep 16, 2020 · 3 comments
Closed

momentjs deprecated #72

mchangrh opened this issue Sep 16, 2020 · 3 comments
Labels
help wanted type/enhancement New feature or request

Comments

@mchangrh
Copy link
Member

Info: https://momentjs.com/docs/#/-project-status/

Alternatives

  • Luxon
  • Day.js
  • date-fns
  • js-Joda
@seanecoffey seanecoffey added type/enhancement New feature or request help wanted labels Oct 16, 2020
@mchangrh
Copy link
Member Author

GCal takes timezones as a param and they can then be adjusted by setting the timezone property

and then formatted through .toLocaleString

thanks @DocValerian

@DocValerian
Copy link
Collaborator

Working on the implementation, also fixing some time based issues that remain

@mchangrh
Copy link
Member Author

there is an implementation of moment that needs to be replaced, probably with pretty-ms

https://github.com/seanecoffey/Niles/blob/1bfc851c93d1c5ecaacbe0a104111a3f5c5fa3c0/handlers/commands.js#L688

@mchangrh mchangrh mentioned this issue Oct 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DocValerian @mchangrh @seanecoffey