-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replacement #12
Comments
@keradus I see just one difference between them. This one backslash php constant also \true \null \false when FOP/php-cs-fixer doesn't do it, it only do it for native function call. I would like to know if this is effective. I tend to think that add backslash on true, false and null appears to me overkill. What about constant like PHP_EOL DIRECTORY_SEPARATOR and all other native constant? |
usually you don't backslash everything in code as is. you either backslash what's crucial for your app, or you backslash everything in artifact build job |
@keradus Thanks for your response :) I will go to php-cs-fixer than, that's only backslash native function. But doesn't backslash constants. |
Nice point. When this code was written php-cs-fixer did not have this feature. |
Hi !
Idea behind this package is really great!
This package is not actively maintained, and
some time ago, one of open-source contributor bring this feature into https://github.com/FriendsOfPHP/PHP-CS-Fixer/ as
native_function_invocation
rule.Maybe you want to deprecate this package and redirect users to PHP CS Fixer to not need to maintain this package ?
The text was updated successfully, but these errors were encountered: