Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacement #12

Closed
keradus opened this issue Sep 17, 2017 · 4 comments
Closed

replacement #12

keradus opened this issue Sep 17, 2017 · 4 comments

Comments

@keradus
Copy link

keradus commented Sep 17, 2017

Hi !
Idea behind this package is really great!

This package is not actively maintained, and
some time ago, one of open-source contributor bring this feature into https://github.com/FriendsOfPHP/PHP-CS-Fixer/ as native_function_invocation rule.

Maybe you want to deprecate this package and redirect users to PHP CS Fixer to not need to maintain this package ?

@ksom
Copy link

ksom commented Apr 9, 2018

@keradus
Hi !

I see just one difference between them. This one backslash php constant also \true \null \false when FOP/php-cs-fixer doesn't do it, it only do it for native function call.

I would like to know if this is effective. I tend to think that add backslash on true, false and null appears to me overkill. What about constant like PHP_EOL DIRECTORY_SEPARATOR and all other native constant?

@keradus
Copy link
Author

keradus commented Apr 9, 2018

usually you don't backslash everything in code as is. you either backslash what's crucial for your app, or you backslash everything in artifact build job

@ksom
Copy link

ksom commented Apr 11, 2018

@keradus Thanks for your response :) I will go to php-cs-fixer than, that's only backslash native function. But doesn't backslash constants.

@nilportugues
Copy link
Owner

Nice point. When this code was written php-cs-fixer did not have this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants