Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save before run #14

Closed
brokeDude2901 opened this issue Nov 7, 2023 · 5 comments
Closed

Save before run #14

brokeDude2901 opened this issue Nov 7, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@brokeDude2901
Copy link

Ability to save before run bat file

@nils-soderman
Copy link
Owner

I like the idea, will look into adding it for the next update!

@nils-soderman nils-soderman added the enhancement New feature or request label Nov 11, 2023
@nils-soderman nils-soderman changed the title Suggested Feature Save before run Nov 11, 2023
@nils-soderman
Copy link
Owner

With the 1.2.0 release you can now set the setting

{
    "batch-runner.saveFileBeforeRun": true
}

to automatically save the batch files before running them.

Full changelog here: https://github.com/nils-soderman/vscode-batch-runner/releases/tag/1.2.0

@lucasc190
Copy link

Is there a reason you didn't make this the default? As far as I know, that's the behaviour in the vast majority of code editors. I can't personally think of any reason why someone would want an easy way to run the current file without making sure it's saved first. I also just think it's more intuitive for an easy command to run the file the user is looking at to run the version of it they're looking at (including any unsaved changes) (i.e. save it first).

@nils-soderman
Copy link
Owner

Hi,

No, no real reason, chose to default it to false just because that was the current behavior of the extension.
But you raise some valid points, and I agree that we should default this to true instead.

@nils-soderman nils-soderman reopened this Feb 4, 2024
@nils-soderman
Copy link
Owner

With the latest release (1.3.0) batch-runner.saveFileBeforeRun now defaults to true.
Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants