Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call setState several times #42

Open
nilshenrich opened this issue Dec 7, 2023 · 1 comment
Open

Don't call setState several times #42

nilshenrich opened this issue Dec 7, 2023 · 1 comment
Labels
enhancement Request for an enhancement in general Performance Anything about performance

Comments

@nilshenrich
Copy link
Owner

The setState is meant to be called just once per frame. Calling it several times from a loop is bad practice.

It is currently done in hash generation progress bar.
@nilshenrich nilshenrich added enhancement Request for an enhancement in general Performance Anything about performance labels Dec 7, 2023
@nilshenrich
Copy link
Owner Author

This will be the new way to update any kind of progress or live element: f653a26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Request for an enhancement in general Performance Anything about performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nilshenrich