Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages should not be indicated by country flags #1514

Closed
qubez opened this issue Sep 21, 2016 · 6 comments
Closed

Languages should not be indicated by country flags #1514

qubez opened this issue Sep 21, 2016 · 6 comments
Milestone

Comments

@qubez
Copy link
Contributor

qubez commented Sep 21, 2016

Just putting this here for comment, the improvements I was thinking of coding would take a bit of work.

  • The flag images take many HTTP requests to load on every page, quick fix is to remove them.
  • Removing flags fixes the basic problem --- country_flag != language.

I can be in Canada and want French. I can be in USA and want Spanish. I may be in Australia and want UK English. Indians may want Kannada, Hindi, Tamil...

  • The language flag is a user setting. This setting should be moved into the "user profile" dialog. The user will only set it once, it should not persist in the menu.
  • Languages should be displayed in a list, as first the spelling in native language, then the system or user's language's translation. For example, with default language set to French, we should show:

[en]English - anglais
[fr]français - français
[de]Deutsch - allemand
[ja]日本語 - japonais
...

This means Teampass has the native language representation hard-coded, and gets the French translation from the language file. Or to allow for better translations, coded in English, but get both displayed languages from language files (but we don't want to hit 20+ language files for this function).

@nilsteampassnet
Copy link
Owner

Hi @qubez

Good idea. It can be easily done ;)

@nilsteampassnet nilsteampassnet added this to the 2.1.27 milestone Sep 21, 2016
@qubez
Copy link
Contributor Author

qubez commented Sep 28, 2016

After digging into the language settings, and realizing I'd want to remove all the manual styling throughout the code (and then need to re-style), I got a bit distracted...:
screenshot-style
Somewhat responsive css now; hopefully this can still merge when finished...

@reginfo
Copy link

reginfo commented Sep 28, 2016

Is it new design coming?

@nilsteampassnet
Copy link
Owner

@qubez, can you please contact me

@qubez
Copy link
Contributor Author

qubez commented Sep 28, 2016

I sent a message via teampass.net contact form.

@nilsteampassnet
Copy link
Owner

Language selection is now done in the Profile dialogbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants