Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WONTFIX] html2karax inserts a root document tag #4

Closed
planetis-m opened this issue May 16, 2021 · 2 comments
Closed

[WONTFIX] html2karax inserts a root document tag #4

planetis-m opened this issue May 16, 2021 · 2 comments

Comments

@planetis-m
Copy link
Collaborator

planetis-m commented May 16, 2021 •
edited
Loading

Actually the htmlparser does that. I have tried two ways to fix this already (seen on git history). The thing is, they were based on heuristics and may cause loosing data (in case there is a document tag), which more serious than some minor inconvenience. The user may have to manually format the output anyway.
@planetis-m
Copy link
Collaborator Author

...except "document" is not a valid html5 tag or even supported by karax. I need more opinions on this...

@planetis-m
Copy link
Collaborator Author

I think time would be spend more constructively, if it could distinguish between single root or not and apply the correct buildHtml overload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@planetis-m