Missing files on launch now show in one dialog #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
reviewed
Oct 20, 2016
| var filenames = "" | ||
| if len(missingFilenames) > 5: | ||
| var numNotShown = len(missingFilenames) - 5 | ||
| filenames = missingFilenames[0..4].join("\n") & "\nand " & intToStr(numNotShown) & " more files" |
There was a problem hiding this comment.
I like this in general but I dislike that I won't be shown some of the missing files.
|
Any preference on how that gets changed?
I find it somewhat annoying when I move a project and I have to click through many dialogs, so personally I'd prefer the first or second option. |
|
What would be ideal is a custom dialog that contains a scrolled text view. But I can understand it if you don't wish to implement this. I'll merge this as-is if that is the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.