Question: Right way to turn a Duration into milliseconds?

[Araq]

This does what the documentation says it would do, I guess, but how to accomplish what I'm trying to do?

import times
var a = initDuration(seconds = 2)
echo a.milliseconds()

Outputs: 0
Expected: 2000

[andreaferretti]

I guess that's not well-defined?

import times
var a = initDuration(months = 2)
echo a.days()

[andreaferretti]

Uh sorry, a Duration cannot have months. Still, given leap seconds, anything above minutes could not be convertible exactly

[GULPF]

@andreaferretti Duration defines a day as exactly 86400 seconds, so it's not an issue in this context.

The reason that I implemented dur.milliseconds this way was because I didn't want something that looks like a field access to cause overflows. I'm not happy about the behavior though, it's confusing and not very useful. To do conversion to milliseconds something like this is required: convert(Seconds, Milliseconds, a.seconds) + a.milliseconds .

[GULPF]

To be honest, maybe the conversion shorthands should just be deprecated and we can add a proc convert(Duration, FixedTimeUnit): int64 instead. That makes it clearer that an overflow can occur, and reduces the api surface. There's way to many one line shorthand procs in the times module.

[dom96]

To be honest, maybe the conversion shorthands should just be deprecated and we can add a proc convert(Duration, FixedTimeUnit): int64 instead.

I think a better option would be to create a asMilliseconds function. It makes it clearer that a conversion is occurring. Only problem I see with this is that it might not be consistent with how we do conversions in the rest of the stdlib, but I don't actually have that on top of my head so it can't be too consistent as it is right now...

[Araq]

Yeah give us asMilliseconds or inMilliseconds shortcuts, convert is too confusing. :-)