New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selectors API encourages signal file descriptor leak #12354
Comments
That is the solution, of course now it'll break code... So silly that So the next best solution is to make the I think we're left with only one option: deprecate |
dom96, what is wrong with making |
One problem I can think of is: what if you have two selectors and register the same FDs into both? |
Why would that be a problem? |
because closing one of the selectors will close FDs that belong to another selector |
Nah. |
As discussed on IRC, this is a problem and I think we should solve this by deprecating |
Appears to be an identical problem with |
I made a selector like this:
This is leaking the file descriptor returned by
registerProcess
.one solution
I would like
close
tounregister
any extant event listeners.another solution
A lesser solution might be to make
registerProcess
not be{.discardable.}
.Thanks to @zevv for help debugging.
The text was updated successfully, but these errors were encountered: