Default value for readLines shouldn't be 1

[dom96]

I was just doing Advent of Code and used readLines in a loop, I was confused to see it return a single line... https://nim-lang.org/docs/io.html#readLines%2Cstring

Example

for line in readLines("blah.txt"):
  echo line

Current Output

One line

Expected Output

All lines

Possible Solution

• Deprecate this function and introduce one that does not have the n as a default argument

[simonkrauter]

This confused me too a while ago.

[zevv]

Are you not better off using io.lines() instead, it being an iterator instead of a proc?

https://nim-lang.org/docs/io.html#lines.i%2Cstring

[cooldome]

io.lines() is always better except cases when it is not available for example in VM.

[Clyybber]

Nowadays this: https://github.com/nim-lang/Nim/pull/12284/files#diff-93574743bf0f766ad08398709499ef6aR18 works in the VM, though its not io.lines