Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

both tools/niminst and nim-lang/niminst are getting updated / diverge; need to mark 1 of those as readonly #15946

Closed
timotheecour opened this issue Nov 13, 2020 · 5 comments
Labels

Comments

@timotheecour
Copy link
Member

timotheecour commented Nov 13, 2020

(extracted from nim-lang/RFCs#206 which sadly got closed despite several points left unaddressed)

As mentioned in nim-lang/RFCs#206, external projects should be moved out of Nim's index; this issue focuses on niminst;

it's pretty bad, both copies (tools/niminst => nim-lang/niminst) have diverged, with different bugs being fixed in both (see #13406 or #15945 which just got sent out).

proposal

Additional Information

devel 1.5.1 1413818

@ringabout
Copy link
Member

ringabout commented Nov 13, 2020

I agree on removing one of them.
And Niminst is missing from installation
#11433

@timotheecour timotheecour changed the title both tools/niminst and nim-lang/niminst are getting updated; need to mark 1 of those as readonly both tools/niminst and nim-lang/niminst are getting updated / diverge; need to mark 1 of those as readonly Nov 13, 2020
@Araq
Copy link
Member

Araq commented Nov 13, 2020

proposal
rebase tools/niminst onto nim-lang/niminst
then remove tools/niminst, and (if needed) install it similarly to #13850 (and preferably in dist)

Accepted. Bring it on please.

@timotheecour
Copy link
Member Author

#17580 (comment)

Instead the niminst Nimble package should be removed.

@xflywind in that case we should:

@ringabout
Copy link
Member

ringabout commented Mar 30, 2021

merge changes from nim-lang/niminst into tools/niminst

no useful additions.

archive https://github.com/nim-lang/niminst after adding a final note in the README pointing to use nim/tools/niminst

it is inconvenient for me. Please someone has rights to do that.

@timotheecour
Copy link
Member Author

no useful additions.

indeed, I just checked as well.

it is inconvenient for me. Please someone has rights to do that.

done; i added a note in https://github.com/nim-lang/niminst description on the right pointing to this issue, and marked it as archived; it can always be unarchived if every needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants