Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor NimNode comment repr() regression 1.0.10 to 1.2.9 #16307

Closed
disruptek opened this issue Dec 10, 2020 · 2 comments · Fixed by #19726
Closed

minor NimNode comment repr() regression 1.0.10 to 1.2.9 #16307

disruptek opened this issue Dec 10, 2020 · 2 comments · Fixed by #19726
Labels
Regression

Comments

@disruptek
Copy link
Contributor

Input

import std/macros

macro bug(x: untyped) =
  echo treeRepr(x)
  echo repr(x)

bug:
  block:
    ## one
    ## two
    ## three

Output

1.0.10

StmtList
  BlockStmt
    Empty
    StmtList
      CommentStmt "one\ntwo\nthree"

block:
  ## one
  ## two
  ## three

1.2.9, 1.4.2, 1.5.1

StmtList
  BlockStmt
    Empty
    StmtList
      CommentStmt "one\ntwo\nthree"

block:
  ## one
       ## two
       ## three
@ringabout
Copy link
Member

caused by 0ac74dd

@ringabout ringabout mentioned this issue Apr 15, 2022
Merged
@ringabout
Copy link
Member

ringabout commented Apr 15, 2022 •
edited

update: #19726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #16307(NimNode comment repr() regression) [backport: 1.2] ringabout/Nim
3 participants
@Araq @disruptek @ringabout