result.add x is not void when result is a NimNode, returns itself

[shirleyquirk]

getting the type of a templated block inside a macro is complicated by the fact that typeof(result.add x) is NimNode and not void

Example

import macros
macro foo():untyped =
  result = nnkStmtList.newNimNode
  var x = nnkDiscardStmt.newTree(newEmptyNode())
  let str = result.add x # compiles ???
  doAssert str == result # ???
  doAssert typeof(result.add x) is NimNode #<= how i found out and what i really care about
foo()

Current Output

asserts all succeed

Expected Output

shouldn't compile; both assertions should fail

[shirleyquirk]

#14665

[Araq]

result.add should not return anything, this is a legacy that predates newTree. For 2.0 we should fix this.

[xigoi]

Maybe in the meantime, it could be useful to add {.discardable.} to prevent errors?