csources submodule

[rbehrends]

The way that the path to the csources submodule is defined (relative to the main repository), means that it won't work unless the active remote is currently on GitHub. In particular, it breaks for local clones.

And the git submodule update --init --depth 1 in build.sh would fail if there's already an older shallow clone (not that we'd get there, because the incorrect [ -e csources/.git ] test doesn't verify that there's actually the proper revision in there).

If this is to be done using git submodules, it needs to be done properly.

[refi64]

I think this is why some people don't like submodules...

[dom96]

indeed. This was not thought out. @Araq should have stuck to his instincts. The submodules will also likely break when we hard reset the C sources repo, which we do from time to time to reduce its size.

[chrisosaurus]

I am at work now so can't work on a patch myself until later.

git --work-tree=csources/ --git-dir=csources/.git show-ref HEAD
will currently yield
15724e2e1f3e7749d508dfcd995e84fea2850802 refs/remotes/origin/HEAD
if we want to check the current csources revision.

[reactormonk]

How about we kick the submodule again and make the script ask if the currently cloned shallow version is equivalent to the upstream version, otherwise delete and reclone?

[Araq]

It's been kicked.