JS codegen. assert statement generates syntactically invalid code.

[yglukhov]

assert(true)

related code in js:

function raiseassert_11879(msg_11881) {
var F={procname:"system.raiseAssert",prev:framePtr,filename:"lib/system.nim",line:0};
framePtr = F;
sysfatal_11884(, msg_11881); // Syntax error here
framePtr = framePtr.prev;
}

[yglukhov]

Git bisect showed the first bad commit: c5db4fc. @def-, could you take a look please?

[def-]

I changed sysFatal from a template to an inline proc. This seems to trigger a bug in the JS backend with procs that take a typedesc:

type T = object
proc f(t: typedesc, s: string) = discard
f(T, "foobar")

This produces wrong JS code for the proc call:

f_14013(, cstrToNimstr("foobar"));

Somehow the first argument in the AST ends up being something totally wrong. In the C backend it's just removed, but I'm not sure where that happens and why it doesn't happen in the JS backend.

[dom96]

Fixed by #2761