Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate repo for RFCs #9378

Closed
timotheecour opened this issue Oct 15, 2018 · 4 comments
Closed

separate repo for RFCs #9378

timotheecour opened this issue Oct 15, 2018 · 4 comments

Comments

@timotheecour
Copy link
Member

timotheecour commented Oct 15, 2018

/cc @Araq @dom96 @narimiran @krux02

Arguments for separate RFC repo:

  • reduces the number of github issues by removing RFC's, so it only contains actual bugs
  • rfc issues are not in my face when I look at github issues
  • RFC's are all in 1 place

discussion

further arguments against separate RFC repo

moving existing RFC issues to https://github.com/nim-lang/rfcs/issues causes all existing links to be broken, eg:

  • a git commit msg #123 or nim-lang/Nim/#123 or full URL
  • likewise with links in source code (including in other repos pointing to nim-lang), or in people's personal notes
  • all votes are gone
  • all messages are shown as @narimiran ; this makes it impossible to find RFC's your authored or search for comments by @someone using the github UI or API (and searching for the name in the body has other issues)
  • once some issue is re-classified as RFC, we'd have to close it and copy it to a separate repo: this doens't make sense.
  • with a separate repo, when searching for a label (eg: "Parser"), you'd now need to search in 2 different repos (rfcs and Nim) instead of 1
  • **now original author can't modify his own RFC or change the title ** (note: good practice for edits is to use EDIT or [EDIT] to avoid confusion) unless he re-creates a new issue, causing more mess (eg loosing comments, votes etc) in the process

Labels are good, use them. Hierarchies (nim-lang/Nim ; nim-lang/rfs) are good for some things, but not for that.

Note: you can use your favorite bookmark mechanism to access issues using customized filters with 1 click (eg in chrome I use bookmark bar)
image

for example : https://github.com/issues?utf8=%E2%9C%93&q=is%3Aissue+author%3Atimotheecour+sort%3Aupdated-desc+ for easy access

@narimiran
Copy link
Member

Let's keep it in one place: https://forum.nim-lang.org/t/4315

@dom96
Copy link
Contributor

dom96 commented Oct 15, 2018

Discussions like this belong on the forum. Closing this.

@dom96 dom96 closed this as completed Oct 15, 2018
@timotheecour timotheecour changed the title rfcs repo is a bad idea r f c s repo is a bad idea Oct 17, 2020
@timotheecour
Copy link
Member Author

(renamed to avoid making this issue show up in google in 2nd position when searching for nim RFCS, now that it's accepted)

@Araq
Copy link
Member

Araq commented Oct 19, 2020

Now that we have the RFCs over there we might as well keep them there, right? :-)

@timotheecour timotheecour changed the title r f c s repo is a bad idea separate repo for RFCs Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants