New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate repo for RFCs #9378
Comments
Let's keep it in one place: https://forum.nim-lang.org/t/4315 |
Discussions like this belong on the forum. Closing this. |
(renamed to avoid making this issue show up in google in 2nd position when searching for nim RFCS, now that it's accepted) |
Now that we have the RFCs over there we might as well keep them there, right? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
/cc @Araq @dom96 @narimiran @krux02
Arguments for separate RFC repo:
discussion
https://github.com/nim-lang/Nim/issues shows a total of (1414 open/4221 closed) issues, of which (88 open, 85 closed) are RFC's (via https://github.com/nim-lang/Nim/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3Arfc) so the number of issues moved to RFC is only 3 percent of total, ie a negligible cleanup
"so it only contains actual bugs" is not practical: it's often a gray area whether an issue is: a bug, feature request, or RFC; it could be a bit of all (that's why we have labels, not hierarchies), or can be re-classified overtime
"rfc issues are not in my face when I look at github issues"
this is bogus: just use negative label filter "is:issue is:open -label:rfc" (which github introduced back in 2014)
https://github.com/nim-lang/Nim/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+-label%3Arfc+
this will filter out from your view all RFC's
RFC's are all in 1 place
this is bogus for same reason: just use a positive filter https://github.com/issues?utf8=%E2%9C%93&q=label%3Arfc+
further arguments against separate RFC repo
moving existing RFC issues to https://github.com/nim-lang/rfcs/issues causes all existing links to be broken, eg:
#123
ornim-lang/Nim/#123
or full URL@narimiran
; this makes it impossible to find RFC's your authored or search for comments by@someone
using the github UI or API (and searching for the name in the body has other issues)Labels are good, use them. Hierarchies (nim-lang/Nim ; nim-lang/rfs) are good for some things, but not for that.
Note: you can use your favorite bookmark mechanism to access issues using customized filters with 1 click (eg in chrome I use bookmark bar)
for example : https://github.com/issues?utf8=%E2%9C%93&q=is%3Aissue+author%3Atimotheecour+sort%3Aupdated-desc+ for easy access
The text was updated successfully, but these errors were encountered: