Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fusion CI should run tests and docs for js #63

Closed
timotheecour opened this issue Jan 2, 2021 · 5 comments
Closed

fusion CI should run tests and docs for js #63

timotheecour opened this issue Jan 2, 2021 · 5 comments

Comments

@timotheecour
Copy link
Member

timotheecour commented Jan 2, 2021 •
edited
Loading

refs #59 (review)

otherwise PR's like this #59 have tests that are never run.

Furthermore, we need to publish docs for js-only modules

/cc @juancarlospaco
@juancarlospaco
Copy link
Contributor

We need someone to merge #54 (comment) ?.
So it can advance further, or should it be mixed in between of that. 🤔

@timotheecour
Copy link
Member Author

ok! refs #54 (comment)

@timotheecour
Copy link
Member Author

Done, merged

@juancarlospaco juancarlospaco mentioned this issue Jan 3, 2021
Merged
@timotheecour
Copy link
Member Author

also related but can be fixed independently: timotheecour/Nim#197

@timotheecour
Copy link
Member Author

timotheecour commented Jan 15, 2021 •
edited
Loading

closing since #64 mostly addressed this, will re-open a new issue to track the rest: #71

@timotheecour timotheecour mentioned this issue Jan 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juancarlospaco @timotheecour